-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xWebAdministration: New folder structure for examples #500
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #500 +/- ##
=======================================
Coverage 91.39% 91.39%
=======================================
Files 17 17
Lines 2661 2661
=======================================
Hits 2432 2432
Misses 229 229 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 25 of 25 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @tomlarse)
a discussion (no related file):
Just a tiny comment. Could you please update the change log with an entry explaining this change?
yeah, sorry. I missed that :) Is that okay, or should the description be different? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries :) It looks good to me
Reviewed 1 of 1 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! all files reviewed, all discussions resolved
@tomlarse Thank you for this! 😄 |
Glad to be of any help 😁 |
- Changes to Examples - Created new folder structure for examples so that examples will be placed in `/Examples/Resources/$resourceName` (issue dsccommunity#483).
Pull Request (PR) description
Directory structure as described in #483. This should probably be merged before work on #484, #485, #486, #487 and #491 is done.
This Pull Request (PR) fixes the following issues
Task list
Entry should say what was changed, and how that affects users (if applicable).
and comment-based help.
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)